]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: use Go function signatures for memclr and memmove comments
authorMichael Munday <mike.munday@ibm.com>
Mon, 21 May 2018 10:22:00 +0000 (11:22 +0100)
committerMichael Munday <mike.munday@ibm.com>
Mon, 21 May 2018 13:18:16 +0000 (13:18 +0000)
The function signatures in the comments used a C-like style. Using
Go function signatures is cleaner.

Change-Id: I1a093ed8fe5df59f3697c613cf3fce58bba4f5c1
Reviewed-on: https://go-review.googlesource.com/113876
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
24 files changed:
src/runtime/memclr_386.s
src/runtime/memclr_amd64.s
src/runtime/memclr_amd64p32.s
src/runtime/memclr_arm.s
src/runtime/memclr_arm64.s
src/runtime/memclr_mips64x.s
src/runtime/memclr_mipsx.s
src/runtime/memclr_plan9_386.s
src/runtime/memclr_plan9_amd64.s
src/runtime/memclr_ppc64x.s
src/runtime/memclr_s390x.s
src/runtime/memclr_wasm.s
src/runtime/memmove_386.s
src/runtime/memmove_amd64.s
src/runtime/memmove_amd64p32.s
src/runtime/memmove_arm.s
src/runtime/memmove_arm64.s
src/runtime/memmove_mips64x.s
src/runtime/memmove_mipsx.s
src/runtime/memmove_plan9_386.s
src/runtime/memmove_plan9_amd64.s
src/runtime/memmove_ppc64x.s
src/runtime/memmove_s390x.s
src/runtime/memmove_wasm.s

index 1adb26b4524e04817bfaf5faf5f1b5eb4a302128..7d5dd38c0a423f37067fc0135811ea89ea91e479 100644 (file)
@@ -8,7 +8,7 @@
 
 // NOTE: Windows externalthreadhandler expects memclr to preserve DX.
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8
        MOVL    ptr+0(FP), DI
        MOVL    n+4(FP), BX
index d0fd50d4f1dc4a86a054ec8c5b88abadb63580d1..63730eebfb3524559f0227d6cc2aba7188a0433c 100644 (file)
@@ -9,7 +9,7 @@
 
 // NOTE: Windows externalthreadhandler expects memclr to preserve DX.
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16
        MOVQ    ptr+0(FP), DI
        MOVQ    n+8(FP), BX
index 26171bfd4ac0ef7545925bd86ac68393ec4b1d36..71040f3750566b3749b536b22ab8f379611c3a1b 100644 (file)
@@ -4,6 +4,7 @@
 
 #include "textflag.h"
 
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
        MOVL    ptr+0(FP), DI
        MOVL    n+4(FP), CX
index eb376743032f65162d61948f8866edeef5de3a2e..ea3c67afc50bdf4d5f651d01ea4a7578dbe2bc43 100644 (file)
@@ -30,6 +30,7 @@
 #define N      R12
 #define TMP    R12                             /* N and TMP don't overlap */
 
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
        MOVW    ptr+0(FP), TO
        MOVW    n+4(FP), N
index 159cac248682015027b511d87c4e847f9e1a1750..c9cdc4b12a8b07d5518b353683c1582a2c23ed21 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
        MOVD    ptr+0(FP), R0
        MOVD    n+8(FP), R1
index 5018d43c8ba04efb8ccd94a9ed4cfab9567331bf..111983bd6ae7e98f38a0e1dbe1d229f9fffd1967 100644 (file)
@@ -6,7 +6,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
        MOVV    ptr+0(FP), R1
        MOVV    n+8(FP), R2
index ad013b84218c9ce32664becced8c9347e023f7fe..1561a23dbe297171a8c4aded6eceb71e4e5636e9 100644 (file)
@@ -14,7 +14,7 @@
 #define MOVWLO  MOVWL
 #endif
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
        MOVW    n+4(FP), R2
        MOVW    ptr+0(FP), R1
index c3d92a9fa9e0292483097b9372419f0f38326f66..5b880ae86f81b43206c55c51ed06a7399be316ae 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8
        MOVL    ptr+0(FP), DI
        MOVL    n+4(FP), BX
index d4d1a3a50b8cc5c51148899fa8e32e35efcc5d78..ad383cd6b3d69c230362b9881eaf4d1cfacbf9de 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
        MOVQ    ptr+0(FP), DI
        MOVQ    n+8(FP), CX
index e3a4673c8d37fbb4e3d1f203cc5a2cb9c3a8a6ca..3b23ce89d87b120acad9345b8fac3eaf4d69cdf4 100644 (file)
@@ -6,7 +6,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT|NOFRAME, $0-16
        MOVD ptr+0(FP), R3
        MOVD n+8(FP), R4
index 43da10dcb6226daaae1fbd3e6a24e11046f63c02..1b2aa3c3b2bf6871bf90024fef4768a254dad1f2 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT|NOFRAME,$0-16
        MOVD    ptr+0(FP), R4
        MOVD    n+8(FP), R5
index d011c845492eb8dae908d68791c6178df0009136..68ffe2f67b513079ad66c6ecf21dc70fd058e224 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memclrNoHeapPointers(void*, uintptr)
+// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16
        MOVD ptr+0(FP), R0
        MOVD n+8(FP), R1
index e76201b48b45a0b9c7538d3156c07dbfb9e0ba42..1bf86a5453b5a476450d78998af009ad621c32fe 100644 (file)
@@ -27,6 +27,7 @@
 
 #include "textflag.h"
 
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-12
        MOVL    to+0(FP), DI
        MOVL    from+4(FP), SI
index 924b11b97b7aae746799eba70db4e72e3b143d4a..aaed67936a76ce68e79db8f93c1db77806cd5bfb 100644 (file)
@@ -27,7 +27,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-24
 
        MOVQ    to+0(FP), DI
index 13907a90b2cb085c5d4c8adb1d1f6451b4e4e19e..8e9fdd14c5e3c09afdd94656598d2d6f47ff273b 100644 (file)
@@ -7,6 +7,7 @@
 // This could use MOVSQ, but we use MOVSL so that if an object ends in
 // a 4 byte pointer, we copy it as a unit instead of byte by byte.
 
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-12
        MOVL    to+0(FP), DI
        MOVL    from+4(FP), SI
index 504ae04c1392dca69ca9724399abaad533c77e86..324b21bf7a5fda61cfa653976a07f59ae2814acd 100644 (file)
@@ -58,6 +58,7 @@
 #define FW3    R4
 #define FR3    R8                                      /* shared with TE */
 
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $4-12
 _memmove:
        MOVW    to+0(FP), TS
index 2faad8df9328ff28d53ea5bf27dac5d84a0f5e8b..dcbead8cf4bfb48e4961b3916b6ec37068a98fbd 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
        MOVD    to+0(FP), R3
        MOVD    from+8(FP), R4
index 54663829a77133c4c03ad6188cd5a15e6102fdac..a4cb7dc81e8800b094ebaf48fb6a6b2342aab88e 100644 (file)
@@ -6,7 +6,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
        MOVV    to+0(FP), R1
        MOVV    from+8(FP), R2
index e934e4d4998c4dcdb0721395a87f19aaf058daf6..13544a3598d4dbe1c75620a27d333d26542f36b6 100644 (file)
@@ -14,7 +14,7 @@
 #define MOVWLO  MOVWL
 #endif
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB),NOSPLIT,$-0-12
        MOVW    n+8(FP), R3
        MOVW    from+4(FP), R2
index 29d44b2f33e45256d1b3f40cd1dd8ce18a35e4e3..7ff01940a2d4c4a79cdeca400dbbf6e46de786e1 100644 (file)
@@ -25,6 +25,7 @@
 
 #include "textflag.h"
 
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-12
        MOVL    to+0(FP), DI
        MOVL    from+4(FP), SI
index a5e8dfa5714701924d8741bd891c266a417860f2..f18b59f3d22ef569d861a4a75230d4c8dc84028c 100644 (file)
@@ -25,7 +25,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-24
 
        MOVQ    to+0(FP), DI
index 26dabd9e6947497cfabcf1dd437c3c78043379ef..b79f76d38874d3209f030484456da27d1e344aaf 100644 (file)
@@ -6,7 +6,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
        MOVD    to+0(FP), R3
        MOVD    from+8(FP), R4
index 238f30891d6074606dd54912d6c8a299e6870a52..94d8be5a47346677ff94d7ba44f4888f31905a70 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB),NOSPLIT|NOFRAME,$0-24
        MOVD    to+0(FP), R6
        MOVD    from+8(FP), R4
index 295272f85f5b81fb98c7d7d327adecf732bde2f1..d5e20169301659b24842d7cb381e068a80d90420 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "textflag.h"
 
-// void runtime·memmove(void*, void*, uintptr)
+// func memmove(to, from unsafe.Pointer, n uintptr)
 TEXT runtime·memmove(SB), NOSPLIT, $0-24
        MOVD to+0(FP), R0
        MOVD from+8(FP), R1