]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/pprof: fix resource leak in documentation
authorRoland Illig <roland.illig@gmx.de>
Mon, 13 Aug 2018 19:28:28 +0000 (21:28 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 22 Aug 2018 19:47:12 +0000 (19:47 +0000)
Fixes #26970

Change-Id: I0f2695434a53550cf84f702e9d8d02a37448d396
Reviewed-on: https://go-review.googlesource.com/129195
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/pprof/pprof.go

index c1024c99ed26a245895347dd8c71119822421682..74cdd15cfbd16b47340df786e39d17d25d72fb8b 100644 (file)
@@ -28,6 +28,7 @@
 //            if err != nil {
 //                log.Fatal("could not create CPU profile: ", err)
 //            }
+//            defer f.Close()
 //            if err := pprof.StartCPUProfile(f); err != nil {
 //                log.Fatal("could not start CPU profile: ", err)
 //            }
 //            if err != nil {
 //                log.Fatal("could not create memory profile: ", err)
 //            }
+//            defer f.Close()
 //            runtime.GC() // get up-to-date statistics
 //            if err := pprof.WriteHeapProfile(f); err != nil {
 //                log.Fatal("could not write memory profile: ", err)
 //            }
-//            f.Close()
 //        }
 //    }
 //