]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/covdata: close cpu and mem profile
authorguoguangwu <guoguangwug@gmail.com>
Wed, 17 Apr 2024 00:58:46 +0000 (00:58 +0000)
committerGopher Robot <gobot@golang.org>
Wed, 17 Apr 2024 16:36:11 +0000 (16:36 +0000)
Change-Id: Iaf14989eb2981f724c4091f992ed99687ce3a60e
GitHub-Last-Rev: 6e6c82bb8fba5c32c24eafb50eec6751a93d09f9
GitHub-Pull-Request: golang/go#66852
Reviewed-on: https://go-review.googlesource.com/c/go/+/579255
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>

src/cmd/covdata/covdata.go

index 95bc30d25dae21e74252b3e1ec8ed498f2cfb06a..549efea20ab71a431222d76b928a5aa86a7506ce 100644 (file)
@@ -176,7 +176,12 @@ func main() {
                if err := pprof.StartCPUProfile(f); err != nil {
                        fatal("%v", err)
                }
-               atExit(pprof.StopCPUProfile)
+               atExit(func() {
+                       pprof.StopCPUProfile()
+                       if err = f.Close(); err != nil {
+                               fatal("error closing cpu profile: %v", err)
+                       }
+               })
        }
        if *memprofileflag != "" {
                if *memprofilerateflag != 0 {
@@ -192,6 +197,9 @@ func main() {
                        if err := pprof.Lookup("heap").WriteTo(f, writeLegacyFormat); err != nil {
                                fatal("%v", err)
                        }
+                       if err = f.Close(); err != nil {
+                               fatal("error closing memory profile: %v", err)
+                       }
                })
        } else {
                // Not doing memory profiling; disable it entirely.