]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: please vet
authorDmitriy Vyukov <dvyukov@google.com>
Fri, 22 Aug 2014 17:27:25 +0000 (21:27 +0400)
committerDmitriy Vyukov <dvyukov@google.com>
Fri, 22 Aug 2014 17:27:25 +0000 (21:27 +0400)
The current code is correct, but vet does not understand it:
asm_amd64.s:963: [amd64] invalid MOVL of ret+0(FP); int64 is 8-byte value
asm_amd64.s:964: [amd64] invalid offset ret+4(FP); expected ret+0(FP)

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://golang.org/cl/125200044

src/pkg/runtime/asm_amd64.s

index 9fcb2318b987be66b6470ea572b1a14dd4cb0ba4..3b63c56a35fb99d192b7c82b751e553ea603ca27 100644 (file)
@@ -955,8 +955,9 @@ TEXT runtime·cputicks(SB),NOSPLIT,$0-0
 
 TEXT runtime·gocputicks(SB),NOSPLIT,$0-8
        RDTSC
-       MOVL    AX, ret+0(FP)
-       MOVL    DX, ret+4(FP)
+       SHLQ    $32, DX
+       ADDQ    DX, AX
+       MOVQ    AX, ret+0(FP)
        RET
 
 TEXT runtime·stackguard(SB),NOSPLIT,$0-16