go/types,types2: move notinheap tests to fixedbugs directory

So they can be added to ignored list, since the tests now require
cgo.Incomplete, which is not recognized by go/types and types2.

Updates #46731

Change-Id: I9f24e3c8605424d1f5f42ae4409437198f4c1326
Reviewed-on: https://go-review.googlesource.com/c/go/+/427142
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>

diff --git a/src/cmd/compile/internal/types2/stdlib_test.go b/src/cmd/compile/internal/types2/stdlib_test.go
index 2577abf6de9b61d4b1bb7a90b7eaf3c9dd4615d8..5933c29d61ba5ec86bd13c239181022be5238ae1 100644 (file)
--- a/src/cmd/compile/internal/types2/stdlib_test.go
+++ b/src/cmd/compile/internal/types2/stdlib_test.go
@@ -206,6 +206,8 @@ func TestStdFixed(t *testing.T) {
                "issue42076.go",
                "issue46903.go",
                "issue51733.go",
+               "notinheap2.go",
+               "notinheap3.go",
        )
 }
 

diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go
index 53333b69db9df00bde1a767eec5a5c6440c1d885..66e75c725114f440e138f1441a39ad3a109f0b7e 100644 (file)
--- a/src/go/types/stdlib_test.go
+++ b/src/go/types/stdlib_test.go
@@ -208,6 +208,8 @@ func TestStdFixed(t *testing.T) {
                "issue42076.go",
                "issue46903.go",
                "issue51733.go",
+               "notinheap2.go",
+               "notinheap3.go",
        )
 }
 

diff --git a/test/notinheap.go b/test/fixedbugs/notinheap.go
similarity index 100%
rename from test/notinheap.go
rename to test/fixedbugs/notinheap.go

diff --git a/test/notinheap2.go b/test/fixedbugs/notinheap2.go
similarity index 100%
rename from test/notinheap2.go
rename to test/fixedbugs/notinheap2.go

diff --git a/test/notinheap3.go b/test/fixedbugs/notinheap3.go
similarity index 100%
rename from test/notinheap3.go
rename to test/fixedbugs/notinheap3.go

diff --git a/test/run.go b/test/run.go
index 3d59e4e523add7317c99e2ba2dbb14ad92b8a5d7..3c5b10ad32c46d7e32fb8518f6986c974ed713c1 100644 (file)
--- a/test/run.go
+++ b/test/run.go
@@ -1965,7 +1965,6 @@ func overlayDir(dstRoot, srcRoot string) error {
 
 // List of files that the compiler cannot errorcheck with the new typechecker (types2).
 var types2Failures = setOf(
-       "notinheap.go",            // types2 doesn't report errors about conversions that are invalid due to //go:notinheap
        "shift1.go",               // types2 reports two new errors which are probably not right
        "fixedbugs/issue10700.go", // types2 should give hint about ptr to interface
        "fixedbugs/issue18331.go", // missing error about misuse of //go:noescape (irgen needs code from noder)
@@ -1973,6 +1972,7 @@ var types2Failures = setOf(
        "fixedbugs/issue20233.go", // types2 reports two instead of one error (preference: 1.17 compiler)
        "fixedbugs/issue20245.go", // types2 reports two instead of one error (preference: 1.17 compiler)
        "fixedbugs/issue31053.go", // types2 reports "unknown field" instead of "cannot refer to unexported field"
+       "fixedbugs/notinheap.go",  // types2 doesn't report errors about conversions that are invalid due to //go:notinheap
 )
 
 var types2Failures32Bit = setOf(