]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: convert TestBuildDryRunWithCgo to the script framework
authorMichael Matloob <matloob@golang.org>
Mon, 13 Jan 2020 16:14:23 +0000 (11:14 -0500)
committerMichael Matloob <matloob@golang.org>
Wed, 19 Feb 2020 22:04:29 +0000 (22:04 +0000)
Part of converting all tests to script framework to improve
test parallelism.

Updates #36320
Updates #17751

Change-Id: I2d14c07c590cc618c66f27fdc3a2bb8120c6d646
Reviewed-on: https://go-review.googlesource.com/c/go/+/214427
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/go_test.go
src/cmd/go/testdata/script/build_dash_n_cgo.txt [new file with mode: 0644]

index 198eafccb14ff3036cc0ca4218cfb465484098fa..afedcb816d81fad7a2fcd201639aa041ad095d73 100644 (file)
@@ -1694,27 +1694,6 @@ func TestShadowingLogic(t *testing.T) {
        }
 }
 
-func TestBuildDryRunWithCgo(t *testing.T) {
-       if !canCgo {
-               t.Skip("skipping because cgo not enabled")
-       }
-
-       tg := testgo(t)
-       defer tg.cleanup()
-       tg.tempFile("foo.go", `package main
-
-/*
-#include <limits.h>
-*/
-import "C"
-
-func main() {
-        println(C.INT_MAX)
-}`)
-       tg.run("build", "-n", tg.path("foo.go"))
-       tg.grepStderrNot(`os.Stat .* no such file or directory`, "unexpected stat of archive file")
-}
-
 func TestCgoDependsOnSyscall(t *testing.T) {
        if testing.Short() {
                t.Skip("skipping test that removes $GOROOT/pkg/*_race in short mode")
diff --git a/src/cmd/go/testdata/script/build_dash_n_cgo.txt b/src/cmd/go/testdata/script/build_dash_n_cgo.txt
new file mode 100644 (file)
index 0000000..3f49ef6
--- /dev/null
@@ -0,0 +1,18 @@
+# Tests golang.org/issue/14944
+
+[!cgo] skip
+
+go build -n foo.go
+! stderr 'os.Stat .* no such file or directory' # there shouldn't be a stat of the archive file
+
+-- foo.go --
+package main
+
+/*
+#include <limits.h>
+*/
+import "C"
+
+func main() {
+        println(C.INT_MAX)
+}
\ No newline at end of file