]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo/internal/testsanitizers: for "leak", use -fsanitize=address
authorIan Lance Taylor <iant@golang.org>
Thu, 6 Mar 2025 20:54:27 +0000 (12:54 -0800)
committerGopher Robot <gobot@golang.org>
Thu, 6 Mar 2025 21:27:16 +0000 (13:27 -0800)
We currently test the leak detector by running "go build -asan",
which will pass -fsanitize=address to the C compiler.
So use that when testing whether the option works.

Fixes #72128

Change-Id: I4efc0b689bfda04c80dbac30a5c757215f297d2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/655535
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/cgo/internal/testsanitizers/cc_test.go

index 193d24d52cfd59eda28558f46f122c9ff221ee39..fa0105b11a5d6c1291d1968540590bad8ea6e95c 100644 (file)
@@ -361,10 +361,18 @@ func configure(sanitizer string) *config {
                return c
        }
 
+       sanitizerOpt := sanitizer
+       // For the leak detector, we use "go build -asan",
+       // which implies the address sanitizer.
+       // We may want to adjust this someday.
+       if sanitizer == "leak" {
+               sanitizerOpt = "address"
+       }
+
        c := &config{
                sanitizer: sanitizer,
-               cFlags:    []string{"-fsanitize=" + sanitizer},
-               ldFlags:   []string{"-fsanitize=" + sanitizer},
+               cFlags:    []string{"-fsanitize=" + sanitizerOpt},
+               ldFlags:   []string{"-fsanitize=" + sanitizerOpt},
        }
 
        if testing.Verbose() {