syscall: replace os.MkdirTemp with T.TempDir

Updates #45402

Change-Id: I573133d6b987e8ac23e3e2018652612af684c755
Reviewed-on: https://go-review.googlesource.com/c/go/+/307990
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>

diff --git a/src/syscall/dirent_test.go b/src/syscall/dirent_test.go
index 8ed3caa9d4831859d0bf576d52fc5d282940e9fb..71b445ba9b533b49022a80cea9b88aba4298d750 100644 (file)
--- a/src/syscall/dirent_test.go
+++ b/src/syscall/dirent_test.go
@@ -27,16 +27,12 @@ func TestDirent(t *testing.T) {
                filenameMinSize = 11
        )
 
-       d, err := os.MkdirTemp("", "dirent-test")
-       if err != nil {
-               t.Fatalf("tempdir: %v", err)
-       }
-       defer os.RemoveAll(d)
+       d := t.TempDir()
        t.Logf("tmpdir: %s", d)
 
        for i, c := range []byte("0123456789") {
                name := string(bytes.Repeat([]byte{c}, filenameMinSize+i))
-               err = os.WriteFile(filepath.Join(d, name), nil, 0644)
+               err := os.WriteFile(filepath.Join(d, name), nil, 0644)
                if err != nil {
                        t.Fatalf("writefile: %v", err)
                }
@@ -93,18 +89,14 @@ func TestDirentRepeat(t *testing.T) {
        }
 
        // Make a directory containing N files
-       d, err := os.MkdirTemp("", "direntRepeat-test")
-       if err != nil {
-               t.Fatalf("tempdir: %v", err)
-       }
-       defer os.RemoveAll(d)
+       d := t.TempDir()
 
        var files []string
        for i := 0; i < N; i++ {
                files = append(files, fmt.Sprintf("file%d", i))
        }
        for _, file := range files {
-               err = os.WriteFile(filepath.Join(d, file), []byte("contents"), 0644)
+               err := os.WriteFile(filepath.Join(d, file), []byte("contents"), 0644)
                if err != nil {
                        t.Fatalf("writefile: %v", err)
                }

diff --git a/src/syscall/getdirentries_test.go b/src/syscall/getdirentries_test.go
index 936c8a163a1b9b6306f4507e9a6d9b21c3c693a7..814e656649b8eda0ae780ce63ddbafc682a9205b 100644 (file)
--- a/src/syscall/getdirentries_test.go
+++ b/src/syscall/getdirentries_test.go
@@ -29,11 +29,7 @@ func testGetdirentries(t *testing.T, count int) {
        if count > 100 && testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
                t.Skip("skipping in -short mode")
        }
-       d, err := os.MkdirTemp("", "getdirentries-test")
-       if err != nil {
-               t.Fatalf("Tempdir: %v", err)
-       }
-       defer os.RemoveAll(d)
+       d := t.TempDir()
        var names []string
        for i := 0; i < count; i++ {
                names = append(names, fmt.Sprintf("file%03d", i))

diff --git a/src/syscall/syscall_unix_test.go b/src/syscall/syscall_unix_test.go
index a05fff5136195c2474284ab428b320c0d519559a..ce56c21ff26382a49185fa8be014eeb4a2b99d14 100644 (file)
--- a/src/syscall/syscall_unix_test.go
+++ b/src/syscall/syscall_unix_test.go
@@ -79,16 +79,12 @@ func TestFcntlFlock(t *testing.T) {
        }
        if os.Getenv("GO_WANT_HELPER_PROCESS") == "" {
                // parent
-               tempDir, err := os.MkdirTemp("", "TestFcntlFlock")
-               if err != nil {
-                       t.Fatalf("Failed to create temp dir: %v", err)
-               }
+               tempDir := t.TempDir()
                name := filepath.Join(tempDir, "TestFcntlFlock")
                fd, err := syscall.Open(name, syscall.O_CREAT|syscall.O_RDWR|syscall.O_CLOEXEC, 0)
                if err != nil {
                        t.Fatalf("Open failed: %v", err)
                }
-               defer os.RemoveAll(tempDir)
                defer syscall.Close(fd)
                if err := syscall.Ftruncate(fd, 1<<20); err != nil {
                        t.Fatalf("Ftruncate(1<<20) failed: %v", err)
@@ -157,11 +153,7 @@ func TestPassFD(t *testing.T) {
 
        }
 
-       tempDir, err := os.MkdirTemp("", "TestPassFD")
-       if err != nil {
-               t.Fatal(err)
-       }
-       defer os.RemoveAll(tempDir)
+       tempDir := t.TempDir()
 
        fds, err := syscall.Socketpair(syscall.AF_LOCAL, syscall.SOCK_STREAM, 0)
        if err != nil {

diff --git a/src/syscall/syscall_windows_test.go b/src/syscall/syscall_windows_test.go
index a9ae54752b30a5a10516c0dd8b5c991f3b61004a..b8ec6bee39bdeabed0a336d64718d87b28fcb0f4 100644 (file)
--- a/src/syscall/syscall_windows_test.go
+++ b/src/syscall/syscall_windows_test.go
@@ -12,11 +12,7 @@ import (
 )
 
 func TestWin32finddata(t *testing.T) {
-       dir, err := os.MkdirTemp("", "go-build")
-       if err != nil {
-               t.Fatalf("failed to create temp directory: %v", err)
-       }
-       defer os.RemoveAll(dir)
+       dir := t.TempDir()
 
        path := filepath.Join(dir, "long_name.and_extension")
        f, err := os.Create(path)