]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: reduce rulelog noise
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 10 May 2019 23:31:56 +0000 (16:31 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Fri, 10 May 2019 23:47:49 +0000 (23:47 +0000)
When the SSA rules are re-generated to log rules,
they write output like:

rewrite AMD64.rules:527
rewrite AMD64.rules:427
rewrite AMD64.rules:494

This is silly; there are no non-rewrite lines in the file.
Furthermore, the rulelog file tends to be gigantic
for any non-trivial compilation (measured in gigabytes).

Remove the "rewrite " prefix.

No impact to normal builds.

Change-Id: I955995c1cc5f27a4a6a3849e19082ecb3e40bd4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/176677
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/compile/internal/ssa/rewrite.go

index 18d9c9f985c6514cfa211d442adf89e29d3bff63..c6b0fa38f3575e0e8ce0d1dd363066084fdc4ad8 100644 (file)
@@ -868,7 +868,7 @@ func logRule(s string) {
                }
                ruleFile = w
        }
-       _, err := fmt.Fprintf(ruleFile, "rewrite %s\n", s)
+       _, err := fmt.Fprintln(ruleFile, s)
        if err != nil {
                panic(err)
        }