]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.17] cmd/objdump: skip TestDisasm* on darwin-arm64
authorHeschi Kreinick <heschi@google.com>
Tue, 10 May 2022 14:49:40 +0000 (10:49 -0400)
committerHeschi Kreinick <heschi@google.com>
Tue, 10 May 2022 15:33:47 +0000 (15:33 +0000)
The macOS 12 builders have an incompatible version of XCode installed.
We fixed the bug on 1.18 but not 1.17.

Updates #49700.

Change-Id: Id356786aad351568ba6665430f093f5f78bb4357
Reviewed-on: https://go-review.googlesource.com/c/go/+/405474
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/objdump/objdump_test.go

index f231a7c6e0e2e5c084cb162c1b6c3540d4677b85..1ce21c46ab5ed539f1ac2647d4fb51b3dfc6f8fe 100644 (file)
@@ -106,6 +106,9 @@ var ppcGnuNeed = []string{
 }
 
 func mustHaveDisasm(t *testing.T) {
+       if strings.HasPrefix(testenv.Builder(), "darwin-arm64") {
+               t.Skipf("builder %q has an incompatible version of XCode installed, see go.dev/issue/49700", testenv.Builder())
+       }
        switch runtime.GOARCH {
        case "mips", "mipsle", "mips64", "mips64le":
                t.Skipf("skipping on %s, issue 12559", runtime.GOARCH)