]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/gc: fix comparison order of parameters in mpcmpfltc(a, b)
authorShenghou Ma <minux.ma@gmail.com>
Mon, 16 Dec 2013 21:54:10 +0000 (16:54 -0500)
committerShenghou Ma <minux.ma@gmail.com>
Mon, 16 Dec 2013 21:54:10 +0000 (16:54 -0500)
It should compare a - b to 0, not b - a to 0.
Fixes #6964.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/39020044

src/cmd/gc/mparith1.c
test/fixedbugs/issue6964.go [new file with mode: 0644]

index e25044a8be2d6caa6ddbcd32dffb37b11d2e1327..41412c416d0fcbe901ac35b7a19be6d7cd0a76d7 100644 (file)
@@ -65,7 +65,7 @@ mpcmpfltc(Mpflt *b, double c)
        Mpflt a;
 
        mpmovecflt(&a, c);
-       return mpcmpfltflt(&a, b);
+       return mpcmpfltflt(b, &a);
 }
 
 void
diff --git a/test/fixedbugs/issue6964.go b/test/fixedbugs/issue6964.go
new file mode 100644 (file)
index 0000000..821735c
--- /dev/null
@@ -0,0 +1,11 @@
+// errorcheck
+
+// Copyright 2013 The Go Authors.  All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+func main() {
+       _ = string(-4 + 2i + 2) // ERROR "-4\+2i"
+}