]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/vet: ignore printf failures in cmd"
authorJosh Bleecher Snyder <josharian@gmail.com>
Sun, 13 Nov 2016 20:59:07 +0000 (12:59 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sun, 13 Nov 2016 21:28:13 +0000 (21:28 +0000)
This reverts commit f15915af4effbbe6895ae69be02d22ac016927d5.

CL 32851 fixed cmd/vet's handling of fmt.Formatter.

Updates #17057.

Change-Id: I3409100d16037645946fe7fe78fbb173e1648494
Reviewed-on: https://go-review.googlesource.com/33166
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/vet/all/main.go

index bcf97777dad9fe874c8c8c719d8c28e3fcaf3635..f4ee8fe15ae374061b2c9002e4d302f035b662ac 100644 (file)
@@ -265,15 +265,6 @@ NextLine:
                        }
                }
 
-               // Temporarily ignore unrecognized printf verbs from cmd.
-               // The compiler now has several fancy verbs (CL 28339)
-               // used with types implementing fmt.Formatters,
-               // and I believe gri has plans to add many more.
-               // TODO: remove when issue 17057 is fixed.
-               if strings.HasPrefix(file, "cmd/") && strings.HasPrefix(msg, "unrecognized printf verb") {
-                       continue
-               }
-
                key := file + ": " + msg
                if w[key] == 0 {
                        // Vet error with no match in the whitelist. Print it.