]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/gc: fix typo in ordermapassign
authorJan Ziak <0xe2.0x9a.0x9b@gmail.com>
Fri, 11 Apr 2014 13:28:37 +0000 (15:28 +0200)
committerJan Ziak <0xe2.0x9a.0x9b@gmail.com>
Fri, 11 Apr 2014 13:28:37 +0000 (15:28 +0200)
Fixes #7742

LGTM=dave, rsc
R=rsc, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/85580047

src/cmd/gc/order.c
test/fixedbugs/issue7742.go [new file with mode: 0644]

index 29eb242b10d610c1bdc36939ec2e0781b008e8d5..d596b0ae189096633534ae22cb96995286714037 100644 (file)
@@ -472,7 +472,7 @@ ordermapassign(Node *n, Order *order)
                                if(!istemp(m->left))
                                        m->left = ordercopyexpr(m->left, m->left->type, order, 0);
                                if(!istemp(m->right))
-                                       m->right = ordercopyexpr(m->left, m->left->type, order, 0);
+                                       m->right = ordercopyexpr(m->right, m->right->type, order, 0);
                                l->n = ordertemp(m->type, order, 0);
                                a = nod(OAS, m, l->n);
                                typecheck(&a, Etop);
diff --git a/test/fixedbugs/issue7742.go b/test/fixedbugs/issue7742.go
new file mode 100644 (file)
index 0000000..dc167c2
--- /dev/null
@@ -0,0 +1,18 @@
+// compile
+
+// Copyright 2014 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Issue 7742: cannot use &autotmp_0001 (type *map[string]string) as type *string in function argument
+
+package main
+
+var (
+       m map[string]string
+       v string
+)
+
+func main() {
+       m[v], _ = v, v
+}