cmd/cgo: avoid leaking fds

Fixes #5714.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/10386043

diff --git a/src/cmd/cgo/gcc.go b/src/cmd/cgo/gcc.go
index bc7a6472f38675c79beb9a87ed076fd44c172e73..8ca680abc91408626ab756e18f5734ea7db01c36 100644 (file)
--- a/src/cmd/cgo/gcc.go
+++ b/src/cmd/cgo/gcc.go
@@ -716,6 +716,7 @@ func (p *Package) gccDebug(stdin []byte) (*dwarf.Data, binary.ByteOrder, []byte)
        runGcc(stdin, p.gccCmd())
 
        if f, err := macho.Open(gccTmp()); err == nil {
+               defer f.Close()
                d, err := f.DWARF()
                if err != nil {
                        fatalf("cannot load DWARF output from %s: %v", gccTmp(), err)
@@ -742,6 +743,7 @@ func (p *Package) gccDebug(stdin []byte) (*dwarf.Data, binary.ByteOrder, []byte)
        }
 
        if f, err := elf.Open(gccTmp()); err == nil {
+               defer f.Close()
                d, err := f.DWARF()
                if err != nil {
                        fatalf("cannot load DWARF output from %s: %v", gccTmp(), err)
@@ -768,6 +770,7 @@ func (p *Package) gccDebug(stdin []byte) (*dwarf.Data, binary.ByteOrder, []byte)
        }
 
        if f, err := pe.Open(gccTmp()); err == nil {
+               defer f.Close()
                d, err := f.DWARF()
                if err != nil {
                        fatalf("cannot load DWARF output from %s: %v", gccTmp(), err)