net: fix failure of TestCVE202133195

TestCVE202133195 fails in testing LookupSRV if /etc/resolv.conf sets the option
'ndots' larger than the number of dots in the domain name under query.

Fix the issue by making the input domain name in test codes 'rooted' to skip search
list qualifying.

Fixes #46955

Change-Id: I1909fa7e54e9c9af57623e57cafc905729ff99fa
Reviewed-on: https://go-review.googlesource.com/c/go/+/330842
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>

diff --git a/src/net/dnsclient_unix_test.go b/src/net/dnsclient_unix_test.go
index a59be7fea0d7a0d1cf3d2a8e3a8a35c2af23da16..d69107a2f23ba614e19fc4c521ec3652ba178e85 100644 (file)
--- a/src/net/dnsclient_unix_test.go
+++ b/src/net/dnsclient_unix_test.go
@@ -1921,12 +1921,12 @@ func TestCVE202133195(t *testing.T) {
                t.Errorf("LookupSRV returned unexpected error, got %q, want %q", err, expected)
        }
 
-       _, _, err = r.LookupSRV(context.Background(), "hdr", "tcp", "golang.org")
-       if expected := "lookup golang.org: SRV header name is invalid"; err == nil || err.Error() != expected {
+       _, _, err = r.LookupSRV(context.Background(), "hdr", "tcp", "golang.org.")
+       if expected := "lookup golang.org.: SRV header name is invalid"; err == nil || err.Error() != expected {
                t.Errorf("Resolver.LookupSRV returned unexpected error, got %q, want %q", err, expected)
        }
-       _, _, err = LookupSRV("hdr", "tcp", "golang.org")
-       if expected := "lookup golang.org: SRV header name is invalid"; err == nil || err.Error() != expected {
+       _, _, err = LookupSRV("hdr", "tcp", "golang.org.")
+       if expected := "lookup golang.org.: SRV header name is invalid"; err == nil || err.Error() != expected {
                t.Errorf("LookupSRV returned unexpected error, got %q, want %q", err, expected)
        }