]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: don't call testing.Fatal from worker goroutines
authorMikio Hara <mikioh.mikioh@gmail.com>
Fri, 5 Feb 2016 00:37:13 +0000 (09:37 +0900)
committerMikio Hara <mikioh.mikioh@gmail.com>
Sun, 7 Feb 2016 03:18:28 +0000 (03:18 +0000)
Change-Id: I630d4d2d8a914d6c07f22351a56d5e44a937123e
Reviewed-on: https://go-review.googlesource.com/19245
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/stack_test.go

index fa073f19adb5f5e5a5f1fd1d80b82ba56ddedf37..928d1eca20a7fec865c412a4157d81a66edc79f9 100644 (file)
@@ -111,7 +111,8 @@ func TestStackGrowth(t *testing.T) {
                select {
                case <-done:
                case <-time.After(20 * time.Second):
-                       t.Fatal("finalizer did not run")
+                       t.Error("finalizer did not run")
+                       return
                }
        }()
        wg.Wait()
@@ -191,7 +192,6 @@ func TestStackGrowthCallback(t *testing.T) {
                        <-done
                })
        }()
-
        wg.Wait()
 }