cmd/dist: do not reinstall runtime/cgo with -tags lldb on ios builders

The cache will take care of keeping go test -tags lldb fast.
Installing runtime/cgo this way just makes all the checkNotStale
tests think runtime/cgo is out of date.

Should fix ios builders.

Fixes #22509.

Change-Id: If092cc4feb189eb848b6a22f6d22b89b70df219c
Reviewed-on: https://go-review.googlesource.com/76020
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 7c0d53efb9f318f7bc7f56fd2c53319e183880d1..9f185af55e500a7b0d10094e949fffd5aa504b29 100644 (file)
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -139,29 +139,6 @@ func (t *tester) run() {
                checkNotStale("go", "std", "cmd")
        }
 
-       if t.iOS() {
-               // Install the Mach exception handler used to intercept
-               // EXC_BAD_ACCESS and convert it into a Go panic. This is
-               // necessary for a Go program running under lldb (the way
-               // we run tests). It is disabled by default because iOS
-               // apps are not allowed to access the exc_server symbol.
-               cmd := exec.Command("go", "install", "-a", "-tags", "lldb", "runtime/cgo")
-               cmd.Stdout = os.Stdout
-               cmd.Stderr = os.Stderr
-               if err := cmd.Run(); err != nil {
-                       log.Fatalf("building mach exception handler: %v", err)
-               }
-
-               defer func() {
-                       cmd := exec.Command("go", "install", "-a", "runtime/cgo")
-                       cmd.Stdout = os.Stdout
-                       cmd.Stderr = os.Stderr
-                       if err := cmd.Run(); err != nil {
-                               log.Fatalf("reverting mach exception handler: %v", err)
-                       }
-               }()
-       }
-
        t.timeoutScale = 1
        switch goarch {
        case "arm":