]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: enable TestLinuxSendfile on mips64
authorVladimir Stefanovic <vladimir.stefanovic@imgtec.com>
Tue, 6 Jun 2017 14:13:39 +0000 (16:13 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 8 Jun 2017 17:27:12 +0000 (17:27 +0000)
The test is passing on a 64bit RFS.

Fixes #18008

Change-Id: Ia4c4f4dde0392c7f6bbe5dbffc97cf848ec5a107
Reviewed-on: https://go-review.googlesource.com/44953
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/fs_test.go

index 1bb24d3060ac4210927c057a66c4fc160e05390a..f1037c4b5c5d433bd6841ad2abd2976aa186e69e 100644 (file)
@@ -1091,12 +1091,10 @@ func TestLinuxSendfile(t *testing.T) {
 
        syscalls := "sendfile,sendfile64"
        switch runtime.GOARCH {
-       case "mips64le", "s390x":
+       case "mips64", "mips64le", "s390x":
                // strace on the above platforms doesn't support sendfile64
                // and will error out if we specify that with `-e trace='.
                syscalls = "sendfile"
-       case "mips64":
-               t.Skip("TODO: update this test to be robust against various versions of strace on mips64. See golang.org/issue/18008")
        }
 
        // Attempt to run strace, and skip on failure - this test requires SYS_PTRACE.