]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: remove darwin-amd64-10_14 builder check
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Fri, 26 Jul 2024 17:09:04 +0000 (00:09 +0700)
committerGopher Robot <gobot@golang.org>
Fri, 26 Jul 2024 17:43:29 +0000 (17:43 +0000)
By now macOS 11 is the minimum required version.

Updates #43926

Change-Id: I13716e2e521c26bd9997f0ea1b717cf72ab7e47c
Reviewed-on: https://go-review.googlesource.com/c/go/+/601276
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/runtime/crash_cgo_test.go

index f9fbdd8f1cd14fd41de8950b3a5acbd813b42a30..57111c9aefa3bec5ac8ceec89497f2cd6360bd9d 100644 (file)
@@ -65,10 +65,6 @@ func TestCgoCallbackGC(t *testing.T) {
                        t.Skip("too slow for mips64x builders")
                }
        }
-       if testenv.Builder() == "darwin-amd64-10_14" {
-               // TODO(#23011): When the 10.14 builders are gone, remove this skip.
-               t.Skip("skipping due to platform bug on macOS 10.14; see https://golang.org/issue/43926")
-       }
        got := runTestProg(t, "testprogcgo", "CgoCallbackGC")
        want := "OK\n"
        if got != want {