]> Cypherpunks repositories - gostls13.git/commitdiff
net: skip TestLookupPort on android with netgo
authorBurcu Dogan <jbd@google.com>
Thu, 3 Mar 2016 02:12:30 +0000 (18:12 -0800)
committerBurcu Dogan <jbd@google.com>
Thu, 3 Mar 2016 02:52:18 +0000 (02:52 +0000)
/etc/services is not available on Android. The pure Go implementation
of LookupPort will never succeed on Android. Skipping the test.

Updates #14576.

Change-Id: I707ac24aea3f988656b95b1816ee5c9690106985
Reviewed-on: https://go-review.googlesource.com/20154
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/lookup_test.go

index 439496ac81d2620383c42df07cb7549d9e8299ec..6307a8612d4121f9fd8c2d164ec7af04204ebf7f 100644 (file)
@@ -624,6 +624,10 @@ func TestLookupPort(t *testing.T) {
        switch runtime.GOOS {
        case "nacl":
                t.Skipf("not supported on %s", runtime.GOOS)
+       case "android":
+               if netGo {
+                       t.Skipf("not supported on %s without cgo; see golang.org/issues/14576", runtime.GOOS)
+               }
        }
 
        for _, tt := range lookupPortTests {