]> Cypherpunks repositories - gostls13.git/commitdiff
os/signal: in TestStop, skip the final "unexpected signal" check for SIGUSR1 on Android
authorBryan C. Mills <bcmills@google.com>
Mon, 30 Mar 2020 19:01:33 +0000 (15:01 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 30 Mar 2020 23:55:51 +0000 (23:55 +0000)
In CL 226138, I updated TestStop to have more uniform behavior for its signals.
However, that test seems to always fail for SIGUSR1 on the Android ARM builders.

I'm not sure what's special about Android for this particular case,
but let's skip the test to unbreak the builders while I investigate.

For #38165
Updates #33174

Change-Id: I35a70346cd9757a92acd505a020bf95e6871405c
Reviewed-on: https://go-review.googlesource.com/c/go/+/226458
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/os/signal/signal_test.go

index a85d7606c837be34c8a7464522a4c717862ec2ce..bec5c1599e6751da6f37da81389b1cf46296662a 100644 (file)
@@ -355,6 +355,9 @@ func TestStop(t *testing.T) {
                        quiesce()
                        select {
                        case s := <-c:
+                               if sig == syscall.SIGUSR1 && s == syscall.SIGUSR1 && runtime.GOOS == "android" {
+                                       testenv.SkipFlaky(t, 38165)
+                               }
                                t.Fatalf("unexpected signal %v", s)
                        default:
                                // nothing to read - good