]> Cypherpunks repositories - gostls13.git/commitdiff
misc/cgo/test: avoid endless loop when we can't parse notes
authorIan Lance Taylor <iant@golang.org>
Thu, 11 Jan 2018 17:53:56 +0000 (09:53 -0800)
committerIan Lance Taylor <iant@golang.org>
Thu, 11 Jan 2018 19:55:49 +0000 (19:55 +0000)
Change-Id: I085870d978a3a560588711882c77060d136d867a
Reviewed-on: https://go-review.googlesource.com/87415
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
misc/cgo/test/buildid_linux.go

index 47dd87128fffb4d0b052a17314334852544585ae..84d3edb664eb25534e998f54c1402dfd1cbc2418 100644 (file)
@@ -27,6 +27,7 @@ func testBuildID(t *testing.T) {
        defer f.Close()
 
        c := 0
+sections:
        for i, s := range f.Sections {
                if s.Type != elf.SHT_NOTE {
                        continue
@@ -47,7 +48,7 @@ func testBuildID(t *testing.T) {
 
                        if len(d) < 12 {
                                t.Logf("note section %d too short (%d < 12)", i, len(d))
-                               continue
+                               continue sections
                        }
 
                        namesz := f.ByteOrder.Uint32(d)
@@ -59,7 +60,7 @@ func testBuildID(t *testing.T) {
 
                        if int(12+an+ad) > len(d) {
                                t.Logf("note section %d too short for header (%d < 12 + align(%d,4) + align(%d,4))", i, len(d), namesz, descsz)
-                               continue
+                               continue sections
                        }
 
                        // 3 == NT_GNU_BUILD_ID