From: Bryan C. Mills <bcmills@google.com>
Date: Tue, 23 Nov 2021 15:39:07 +0000 (-0500)
Subject: runtime: skip TestCgoCallbackGC on darwin-amd64-10_14 builder
X-Git-Tag: go1.18beta1~201
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=00045b76e50d98db354aa185bcbd60a6f62499ac;p=gostls13.git

runtime: skip TestCgoCallbackGC on darwin-amd64-10_14 builder

This test occasionally fails due to a real bug on this platform.
Due to the age of the platform and the rarity of the failure, we do
not believe that the bug is worth working around.

Fixes #43926

Change-Id: Ia227c5afe81fc21b6630813228f976cc3a54013c
Reviewed-on: https://go-review.googlesource.com/c/go/+/366537
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
---

diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
index 9a174fa549..45ee6d6905 100644
--- a/src/runtime/crash_cgo_test.go
+++ b/src/runtime/crash_cgo_test.go
@@ -64,6 +64,10 @@ func TestCgoCallbackGC(t *testing.T) {
 			t.Skip("too slow for mips64x builders")
 		}
 	}
+	if testenv.Builder() == "darwin-amd64-10_14" {
+		// TODO(#23011): When the 10.14 builders are gone, remove this skip.
+		t.Skip("skipping due to platform bug on macOS 10.14; see https://golang.org/issue/43926")
+	}
 	got := runTestProg(t, "testprogcgo", "CgoCallbackGC")
 	want := "OK\n"
 	if got != want {