From: Russ Cox Date: Wed, 15 May 2019 18:31:10 +0000 (-0400) Subject: runtime: disable some tests in -quick mode X-Git-Tag: go1.13beta1~280 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=018d9b42a789809198bb0bcc338d9948a479b108;p=gostls13.git runtime: disable some tests in -quick mode Speeds up the "go test runtime -cpu=1,2,4 -short -quick" phase of all.bash. For #26473. Change-Id: I090f5a5aa754462b3253a2156dc31fa67ce7af2a Reviewed-on: https://go-review.googlesource.com/c/go/+/177399 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick Reviewed-by: Austin Clements --- diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go index 14f418cf97..ce227feebd 100644 --- a/src/runtime/crash_unix_test.go +++ b/src/runtime/crash_unix_test.go @@ -34,6 +34,10 @@ func init() { } func TestCrashDumpsAllThreads(t *testing.T) { + if *flagQuick { + t.Skip("-quick") + } + switch runtime.GOOS { case "darwin", "dragonfly", "freebsd", "linux", "netbsd", "openbsd", "illumos", "solaris": default: diff --git a/src/runtime/memmove_test.go b/src/runtime/memmove_test.go index b490cd815f..0b2e19123d 100644 --- a/src/runtime/memmove_test.go +++ b/src/runtime/memmove_test.go @@ -15,6 +15,9 @@ import ( ) func TestMemmove(t *testing.T) { + if *flagQuick { + t.Skip("-quick") + } t.Parallel() size := 256 if testing.Short() { @@ -54,6 +57,9 @@ func TestMemmove(t *testing.T) { } func TestMemmoveAlias(t *testing.T) { + if *flagQuick { + t.Skip("-quick") + } t.Parallel() size := 256 if testing.Short() { diff --git a/src/runtime/semasleep_test.go b/src/runtime/semasleep_test.go index 5b2cc64483..b931095619 100644 --- a/src/runtime/semasleep_test.go +++ b/src/runtime/semasleep_test.go @@ -21,6 +21,9 @@ import ( // shouldn't cause semasleep to retry with the same timeout which would // cause indefinite spinning. func TestSpuriousWakeupsNeverHangSemasleep(t *testing.T) { + if *flagQuick { + t.Skip("-quick") + } testenv.MustHaveGoBuild(t) tempDir, err := ioutil.TempDir("", "issue-27250") if err != nil { diff --git a/src/runtime/stack_test.go b/src/runtime/stack_test.go index 7bc63967bb..df73b3a1d5 100644 --- a/src/runtime/stack_test.go +++ b/src/runtime/stack_test.go @@ -78,6 +78,10 @@ func TestStackMem(t *testing.T) { // Test stack growing in different contexts. func TestStackGrowth(t *testing.T) { + if *flagQuick { + t.Skip("-quick") + } + if GOARCH == "wasm" { t.Skip("fails on wasm (too slow?)") }