From: Russ Cox <rsc@golang.org>
Date: Wed, 16 Jul 2014 23:26:36 +0000 (-0400)
Subject: liblink: fix precedence bug in pcdata comparison
X-Git-Tag: go1.4beta1~1083
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=055dfc204c7b2c8eae1603b09fe71deb73f0e627;p=gostls13.git

liblink: fix precedence bug in pcdata comparison

As written, the ! applies before the &1.
This would crash writing out missing pcdata tables
if we ever used non-contiguous IDs in a function.
We don't, but fix anyway.

LGTM=iant, minux
R=minux, iant
CC=golang-codereviews
https://golang.org/cl/117810047
---

diff --git a/src/liblink/pcln.c b/src/liblink/pcln.c
index 4b2b85543e..f0ee1dc672 100644
--- a/src/liblink/pcln.c
+++ b/src/liblink/pcln.c
@@ -279,7 +279,7 @@ linkpcln(Link *ctxt, LSym *cursym)
 	}
 	// pcdata.
 	for(i=0; i<npcdata; i++) {
-		if(!(havepc[i/32]>>(i%32))&1) 
+		if(((havepc[i/32]>>(i%32))&1) == 0) 
 			continue;
 		funcpctab(ctxt, &pcln->pcdata[i], cursym, "pctopcdata", pctopcdata, (void*)(uintptr)i);
 	}