From: Tyler Bunnell Date: Wed, 13 Mar 2013 18:49:24 +0000 (-0400) Subject: net: use original raddr if getpeername fails X-Git-Tag: go1.1rc2~527 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=06cbe78bd77789afb46b597466bcecf73c25d6d2;p=gostls13.git net: use original raddr if getpeername fails Fixes #3838. R=dave, mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/7511043 --- diff --git a/src/pkg/net/ipraw_test.go b/src/pkg/net/ipraw_test.go index 3cf8297e43..fa1a535b7f 100644 --- a/src/pkg/net/ipraw_test.go +++ b/src/pkg/net/ipraw_test.go @@ -337,3 +337,19 @@ func TestIPConnLocalName(t *testing.T) { } } } + +func TestIPConnRemoteName(t *testing.T) { + if os.Getuid() != 0 { + t.Skip("skipping test; must be root") + } + + raddr := &IPAddr{IP: IPv4(127, 0, 0, 10).To4()} + c, err := DialIP("ip:tcp", &IPAddr{IP: IPv4(127, 0, 0, 1)}, raddr) + if err != nil { + t.Fatalf("DialIP failed: %v", err) + } + defer c.Close() + if !reflect.DeepEqual(raddr, c.RemoteAddr()) { + t.Fatalf("got %#v, expected %#v", c.RemoteAddr(), raddr) + } +} diff --git a/src/pkg/net/sock_posix.go b/src/pkg/net/sock_posix.go index 74b671c895..2ebde87998 100644 --- a/src/pkg/net/sock_posix.go +++ b/src/pkg/net/sock_posix.go @@ -67,5 +67,8 @@ func socket(net string, f, t, p int, ipv6only bool, ulsa, ursa syscall.Sockaddr, rsa, _ := syscall.Getpeername(s) raddr := toAddr(rsa) fd.setAddr(laddr, raddr) + if fd.raddr == nil { + fd.raddr = toAddr(ursa) + } return fd, nil }