From: Sofía Celi Date: Thu, 26 Aug 2021 12:52:02 +0000 (+0000) Subject: [dev.boringcrypto] crypto/tls: use correct config in TestBoringClientHello X-Git-Tag: go1.19beta1~484^2~42 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=083811d079a659f459eaad4a9dbafec7a50e1a20;p=gostls13.git [dev.boringcrypto] crypto/tls: use correct config in TestBoringClientHello The existing implementation sets the ClientConfig to specific values to check, but does not uses it in the actual testing. This commit make the test to actually use it, which can be used to flag bugs in the future. Change-Id: I8d883c11675169705771af3fcca11a303cfeb30f GitHub-Last-Rev: 37841fd3561c95c8c9143c9fa4fff81268e18cdc GitHub-Pull-Request: golang/go#47959 Reviewed-on: https://go-review.googlesource.com/c/go/+/345029 Reviewed-by: Filippo Valsorda Reviewed-by: Dmitri Shuralyov Run-TryBot: Filippo Valsorda TryBot-Result: Go Bot Trust: Dmitri Shuralyov --- diff --git a/src/crypto/tls/boring_test.go b/src/crypto/tls/boring_test.go index 6ad72faebf..8dd477a021 100644 --- a/src/crypto/tls/boring_test.go +++ b/src/crypto/tls/boring_test.go @@ -264,7 +264,7 @@ func TestBoringClientHello(t *testing.T) { clientConfig.CipherSuites = allCipherSuites() clientConfig.CurvePreferences = defaultCurvePreferences - go Client(c, testConfig).Handshake() + go Client(c, clientConfig).Handshake() srv := Server(s, testConfig) msg, err := srv.readHandshake() if err != nil {