From: Hiroshi Ioka <hirochachacha@gmail.com>
Date: Tue, 19 Sep 2017 07:31:03 +0000 (+0900)
Subject: cmd/go: fix file leak in TestBuildmodePIE
X-Git-Tag: go1.10beta1~1075
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=0bbb6665d85c1e80c3b479a4c00dc8a0a1b83ec8;p=gostls13.git

cmd/go: fix file leak in TestBuildmodePIE

Change-Id: Ifeb93f6dc75fb5f90d595211fb0f97a89bf74526
Reviewed-on: https://go-review.googlesource.com/64530
Reviewed-by: Dave Cheney <dave@cheney.net>
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
index e7f0668f7e..eaa2d0f68d 100644
--- a/src/cmd/go/go_test.go
+++ b/src/cmd/go/go_test.go
@@ -4474,6 +4474,7 @@ func TestBuildmodePIE(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
+		defer f.Close()
 		if f.Type != elf.ET_DYN {
 			t.Errorf("PIE type must be ET_DYN, but %s", f.Type)
 		}
@@ -4482,6 +4483,7 @@ func TestBuildmodePIE(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
+		defer f.Close()
 		if f.Flags&macho.FlagDyldLink == 0 {
 			t.Error("PIE must have DyldLink flag, but not")
 		}