From: Josh Bleecher Snyder <josharian@gmail.com>
Date: Fri, 21 Apr 2017 14:58:03 +0000 (-0700)
Subject: cmd/compile: unexport types.Sym.LSym
X-Git-Tag: go1.9beta1~567
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=0d50a49f5c3fb6292b43d71579455cf68a1939d9;p=gostls13.git

cmd/compile: unexport types.Sym.LSym

Response to code review feedback on CL 40693.

Remove the final reference to it from package gc,
and manually unexport.

Passes toolstash-check.

Change-Id: I7fc48edd43263d8f7c56b47aeb7573408463dc22
Reviewed-on: https://go-review.googlesource.com/41303
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
---

diff --git a/src/cmd/compile/internal/gc/reflect.go b/src/cmd/compile/internal/gc/reflect.go
index a80048cd8e..546cdc69c8 100644
--- a/src/cmd/compile/internal/gc/reflect.go
+++ b/src/cmd/compile/internal/gc/reflect.go
@@ -1338,7 +1338,8 @@ ok:
 			keep = true
 		}
 	}
-	s.Lsym.Set(obj.AttrMakeTypelink, keep)
+	// TODO(josharian): add lsym local variable above, use here instead of calling Linksym()
+	s.Linksym().Set(obj.AttrMakeTypelink, keep)
 
 	return s
 }
diff --git a/src/cmd/compile/internal/types/sym.go b/src/cmd/compile/internal/types/sym.go
index 92be6ca1a6..c969f96b47 100644
--- a/src/cmd/compile/internal/types/sym.go
+++ b/src/cmd/compile/internal/types/sym.go
@@ -31,7 +31,7 @@ type Sym struct {
 	flags   bitset8
 	Label   *Node // corresponding label (ephemeral)
 	Origpkg *Pkg  // original package for . import
-	Lsym    *obj.LSym
+	lsym    *obj.LSym
 }
 
 const (
@@ -78,8 +78,8 @@ func (sym *Sym) Linksym() *obj.LSym {
 	if sym == nil {
 		return nil
 	}
-	if sym.Lsym == nil {
-		sym.Lsym = Ctxt.Lookup(sym.LinksymName())
+	if sym.lsym == nil {
+		sym.lsym = Ctxt.Lookup(sym.LinksymName())
 	}
-	return sym.Lsym
+	return sym.lsym
 }