From: Robert Griesemer Date: Tue, 23 Mar 2021 19:11:26 +0000 (-0700) Subject: cmd/compile/internal/types2: review of check.go X-Git-Tag: go1.17beta1~974 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=0fc595ec99;p=gostls13.git cmd/compile/internal/types2: review of check.go The changes between (equivalent, and reviewed) go/types/check.go and check.go can be seen by comparing patchset 1 and 2. The actual changes are removing the "// UNREVIEWED" marker. The primary differences to go/types/check.go are: - use of syntax instead of go/ast package - tracing is controlled via flag not the "trace" constant Change-Id: I1c9998afb3e0b7e29f5b169d3a4054cf22841490 Reviewed-on: https://go-review.googlesource.com/c/go/+/304109 Reviewed-by: Robert Findley Trust: Robert Griesemer --- diff --git a/src/cmd/compile/internal/types2/check.go b/src/cmd/compile/internal/types2/check.go index c65666e802..7d499eb13d 100644 --- a/src/cmd/compile/internal/types2/check.go +++ b/src/cmd/compile/internal/types2/check.go @@ -1,4 +1,3 @@ -// UNREVIEWED // Copyright 2011 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. @@ -17,7 +16,7 @@ import ( var nopos syntax.Pos // debugging/development support -const debug = true // leave on during development +const debug = false // leave on during development // If forceStrict is set, the type-checker enforces additional // rules not specified by the Go 1 spec, but which will