From: Austin Clements Date: Tue, 2 Jun 2015 18:48:12 +0000 (-0400) Subject: runtime: print start of GC cycle in gctrace, rather than end X-Git-Tag: go1.5beta1~409 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=10083d80079055aa5e7946f3f4972fc4d8c296f1;p=gostls13.git runtime: print start of GC cycle in gctrace, rather than end Currently the GODEBUG=gctrace=1 trace line includes "@n.nnns" to indicate the time that the GC cycle ended relative to the time the program started. This was meant to be consistent with the utilization as of the end of the cycle, which is printed next on the trace line, but it winds up just being confusing and unexpected. Change the trace line to include the time that the GC cycle started relative to the time the program started. Change-Id: I7d64580cd696eb17540716d3e8a74a9d6ae50650 Reviewed-on: https://go-review.googlesource.com/10634 Reviewed-by: Rick Hudson Reviewed-by: Russ Cox --- diff --git a/src/runtime/mgc.go b/src/runtime/mgc.go index f5877e6847..71b083b29c 100644 --- a/src/runtime/mgc.go +++ b/src/runtime/mgc.go @@ -1006,7 +1006,7 @@ func gc(mode int) { var sbuf [24]byte printlock() print("gc #", memstats.numgc, - " @", string(itoaDiv(sbuf[:], uint64(tEnd-runtimeInitTime)/1e6, 3)), "s ", + " @", string(itoaDiv(sbuf[:], uint64(tSweepTerm-runtimeInitTime)/1e6, 3)), "s ", util, "%: ") prev := tSweepTerm for i, ns := range []int64{tScan, tInstallWB, tMark, tMarkTerm, tEnd} {