From: Daniel Martí <mvdan@mvdan.cc>
Date: Wed, 16 Nov 2016 12:26:23 +0000 (+0000)
Subject: testing: comment out flag.Parse from example
X-Git-Tag: go1.8beta1~53
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=111064925b34bfd60949c09f0d0b06c8f34430f2;p=gostls13.git

testing: comment out flag.Parse from example

The TestMain docs explain that flag.Parse() should be called if TestMain
itself depends on command-line flags.

The issue here is that the example implementation does not use any
flags, and thus the flag.Parse call is unnecessary. This leads to people
who use this example as a starting point for their own implementations
to forget that the call is not necessary in most cases.

Comment it out instead of removing the line to keep it as a reminder, as
suggested by Minux Ma.

Change-Id: I6ffc5413e7036366ae3cf0f069b7065e832a3b45
Reviewed-on: https://go-review.googlesource.com/33273
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
---

diff --git a/src/testing/testing.go b/src/testing/testing.go
index 01f5da31d7..f08c5c6b8e 100644
--- a/src/testing/testing.go
+++ b/src/testing/testing.go
@@ -196,7 +196,7 @@
 // A simple implementation of TestMain is:
 //
 //	func TestMain(m *testing.M) {
-//		flag.Parse()
+//		// call flag.Parse() here if TestMain uses flags
 //		os.Exit(m.Run())
 //	}
 //