From: Robert Griesemer <gri@golang.org>
Date: Thu, 24 Feb 2011 18:22:32 +0000 (-0800)
Subject: godoc: log errors when reading filter files
X-Git-Tag: weekly.2011-02-24~10
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=11bda7df47de8cb02d77750351e90419cc946173;p=gostls13.git

godoc: log errors when reading filter files

R=r, r2
CC=golang-dev
https://golang.org/cl/4230042
---

diff --git a/src/cmd/godoc/godoc.go b/src/cmd/godoc/godoc.go
index c0943cd608..957935125e 100644
--- a/src/cmd/godoc/godoc.go
+++ b/src/cmd/godoc/godoc.go
@@ -148,8 +148,13 @@ func readDirList(filename string) ([]string, os.Error) {
 	}
 	// create a sorted list of valid directory names
 	filter := func(path string) bool {
-		d, err := os.Lstat(path)
-		return err == nil && isPkgDir(d)
+		d, e := os.Lstat(path)
+		if e != nil && err == nil {
+			// remember first error and return it from readDirList
+			// so we have at least some information if things go bad
+			err = e
+		}
+		return e == nil && isPkgDir(d)
 	}
 	list := canonicalizePaths(strings.Split(string(contents), "\n", -1), filter)
 	// for each parent path, remove all it's children q
@@ -161,7 +166,7 @@ func readDirList(filename string) ([]string, os.Error) {
 			i++
 		}
 	}
-	return list[0:i], nil
+	return list[0:i], err
 }