From: David Symonds <dsymonds@golang.org>
Date: Fri, 16 Mar 2012 06:28:16 +0000 (+1100)
Subject: reflect: panic if MakeSlice is given bad len/cap arguments.
X-Git-Tag: weekly.2012-03-22~63
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=11cc5a26d51bb707e6e40c796827f5b3a9b6be04;p=gostls13.git

reflect: panic if MakeSlice is given bad len/cap arguments.

Fixes #3330.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5847043
---

diff --git a/src/pkg/reflect/value.go b/src/pkg/reflect/value.go
index 3974d02b71..79476ad229 100644
--- a/src/pkg/reflect/value.go
+++ b/src/pkg/reflect/value.go
@@ -1632,6 +1632,15 @@ func MakeSlice(typ Type, len, cap int) Value {
 	if typ.Kind() != Slice {
 		panic("reflect.MakeSlice of non-slice type")
 	}
+	if len < 0 {
+		panic("reflect.MakeSlice: negative len")
+	}
+	if cap < 0 {
+		panic("reflect.MakeSlice: negative cap")
+	}
+	if len > cap {
+		panic("reflect.MakeSlice: len > cap")
+	}
 
 	// Declare slice so that gc can see the base pointer in it.
 	var x []byte