From: Rob Pike Date: Tue, 3 Nov 2009 04:35:52 +0000 (-0800) Subject: forgot to count newlines when scanning white space. X-Git-Tag: weekly.2009-11-06~121 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=120d0b50c647d13e35f00fbb01de49d1dd0af2fe;p=gostls13.git forgot to count newlines when scanning white space. also fix a error-printing bug in godoc. R=gri http://go/go-review/1016030 --- diff --git a/src/cmd/godoc/godoc.go b/src/cmd/godoc/godoc.go index 8b28082a19..cd438a9b2c 100644 --- a/src/cmd/godoc/godoc.go +++ b/src/cmd/godoc/godoc.go @@ -446,8 +446,8 @@ func readTemplate(name string) *template.Template { if err != nil { log.Exitf("ReadFile %s: %v", path, err); } - t, err1 := template.Parse(string(data), fmap); - if err1 != nil { + t, err := template.Parse(string(data), fmap); + if err != nil { log.Exitf("%s: %v", name, err); } return t; diff --git a/src/pkg/template/template.go b/src/pkg/template/template.go index 9af8577deb..cd0514ba22 100644 --- a/src/pkg/template/template.go +++ b/src/pkg/template/template.go @@ -275,6 +275,7 @@ Loop: // consume trailing white space for ; i < len(t.buf) && white(t.buf[i]); i++ { if t.buf[i] == '\n' { + t.linenum++; i++; break // stop after newline } @@ -850,7 +851,7 @@ func (t *Template) Parse(s string) os.Error { } t.buf = strings.Bytes(s); t.p = 0; - t.linenum = 0; + t.linenum = 1; t.parse(); return t.error; }