From: nobishino Date: Mon, 13 May 2024 21:31:18 +0000 (+0000) Subject: encoding/csv: clarify that Writer uses different line break than RFC 4180 by default X-Git-Tag: go1.23rc1~369 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=133cdfb46979064fcf359598dd2dd93ffa57cf3c;p=gostls13.git encoding/csv: clarify that Writer uses different line break than RFC 4180 by default Package documentation of encoding/csv says: > this package supports the format described in RFC 4180. According to section 2 of RFC 4180: > Each record is located on a separate line, delimited by a line break (CRLF). On the other hand, Writer uses LF (not CRLF) as newline character by default. > If [Writer.UseCRLF] is true, the Writer ends each output line with \r\n instead of \n. Strictly speaking, this behavior is different from RFC 4180. Package documentation would improve if we clarify that point. Change-Id: I120e9332b593e1ac9ed8e49f6f8419ea88efc57d GitHub-Last-Rev: 489167eb04331fa5c623f3da9041a9d34aa258ae GitHub-Pull-Request: golang/go#67290 Reviewed-on: https://go-review.googlesource.com/c/go/+/584835 LUCI-TryBot-Result: Go LUCI Auto-Submit: Dmitri Shuralyov Reviewed-by: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov --- diff --git a/src/encoding/csv/reader.go b/src/encoding/csv/reader.go index d9cab86572..df4702fede 100644 --- a/src/encoding/csv/reader.go +++ b/src/encoding/csv/reader.go @@ -4,7 +4,8 @@ // Package csv reads and writes comma-separated values (CSV) files. // There are many kinds of CSV files; this package supports the format -// described in RFC 4180. +// described in RFC 4180, except that [Writer] uses LF +// instead of CRLF as newline character by default. // // A csv file contains zero or more records of one or more fields per record. // Each record is separated by the newline character. The final record may