From: Andrew Gerrand Date: Tue, 17 Dec 2013 01:17:56 +0000 (+1100) Subject: cmd/go: set GOROOT when testing "go install cmd/fix" X-Git-Tag: go1.3beta1~1214 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1561230ca02e6e71afbf5f524fa89a4a5e3fab9a;p=gostls13.git cmd/go: set GOROOT when testing "go install cmd/fix" This particular test would never pass unless you had GOROOT set in your environment. This changes makes the test use the baked-in GOROOT, as it does with GOOS and GOARCH. R=golang-dev, dave, iant CC=golang-dev https://golang.org/cl/43080043 --- diff --git a/src/cmd/go/test.bash b/src/cmd/go/test.bash index f71d678182..6c6cb9ed78 100755 --- a/src/cmd/go/test.bash +++ b/src/cmd/go/test.bash @@ -36,8 +36,9 @@ stop() { ok=true allok=true -unset GOPATH unset GOBIN +unset GOPATH +unset GOROOT TEST 'file:line in error messages' # Test that error messages have file:line information at beginning of @@ -258,6 +259,7 @@ if [ ! -x $d/gobin/godoc ]; then fi TEST godoc installs into GOROOT +GOROOT=$(./testgo env GOROOT) rm -f $GOROOT/bin/godoc ./testgo install code.google.com/p/go.tools/cmd/godoc if [ ! -x $GOROOT/bin/godoc ]; then