From: Shawn Smith Date: Mon, 6 Jan 2014 18:32:07 +0000 (-0800) Subject: time: add tests for Tick, NewTicker with negative duration X-Git-Tag: go1.3beta1~1051 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=16134060dea378618b7fa4f2accd6cd4831541f0;p=gostls13.git time: add tests for Tick, NewTicker with negative duration R=golang-codereviews, gobot, r, bradfitz CC=golang-codereviews https://golang.org/cl/37660044 --- diff --git a/src/pkg/time/tick_test.go b/src/pkg/time/tick_test.go index d8a086ceb2..32f4740ad9 100644 --- a/src/pkg/time/tick_test.go +++ b/src/pkg/time/tick_test.go @@ -48,6 +48,24 @@ func TestTeardown(t *testing.T) { } } +// Test the Tick convenience wrapper. +func TestTick(t *testing.T) { + // Test that giving a negative duration returns nil. + if got := Tick(-1); got != nil { + t.Errorf("Tick(-1) = %v; want nil", got) + } +} + +// Test that NewTicker panics when given a duration less than zero. +func TestNewTickerLtZeroDuration(t *testing.T) { + defer func() { + if err := recover(); err == nil { + t.Errorf("NewTicker(-1) should have panicked") + } + }() + NewTicker(-1) +} + func BenchmarkTicker(b *testing.B) { ticker := NewTicker(1) b.ResetTimer()