From: Austin Clements Date: Fri, 23 Oct 2015 17:59:08 +0000 (-0400) Subject: runtime: note a minor issue with GODEUG=gcstoptheworld X-Git-Tag: go1.6beta1~623 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1698018955a712608476892798c992b99aad101a;p=gostls13.git runtime: note a minor issue with GODEUG=gcstoptheworld Change-Id: I91cda8d88b0852cd0f868d33c594206bcca0c386 Reviewed-on: https://go-review.googlesource.com/16352 Reviewed-by: Rick Hudson --- diff --git a/src/runtime/mgc.go b/src/runtime/mgc.go index 88cee5b8f6..235c1aac5d 100644 --- a/src/runtime/mgc.go +++ b/src/runtime/mgc.go @@ -916,6 +916,9 @@ func startGC(mode gcMode, forceTrigger bool) { releasem(mp) mp = nil + // TODO: In gcstoptheworld debug mode, multiple goroutines may + // detect the heap trigger simultaneously and then start + // multiple STW GCs, which will run sequentially. if debug.gcstoptheworld == 1 { mode = gcForceMode } else if debug.gcstoptheworld == 2 {