From: Joel Sing <joel@sing.id.au>
Date: Wed, 8 Nov 2023 12:29:50 +0000 (+1100)
Subject: cmd/dist,internal/platform: temporarily disable race detector on openbsd/amd64
X-Git-Tag: go1.23rc1~469
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=17fce6323988d20d104b92c110b8be0ceb526051;p=gostls13.git

cmd/dist,internal/platform: temporarily disable race detector on openbsd/amd64

Unfortunately, LLVM TSAN decided to remove OpenBSD support, which
means that the syso files cannot currently be regenerated (see #52090).
The race_openbsd.syso contains a reference to the syscall symbol,
which has been removed from OpenBSD's libc in 7.5. As such, this
means that the race detector no longer works on openbsd/amd64 (at
least until LLVM TSAN support is reinstated for OpenBSD).

Updates #63900

Change-Id: I3474fc43a94e5197815862b7dc420b71d5e08815
Reviewed-on: https://go-review.googlesource.com/c/go/+/582255
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 6f4d23182a..a87c2a1aae 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -1585,7 +1585,7 @@ func raceDetectorSupported(goos, goarch string) bool {
 		return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x"
 	case "darwin":
 		return goarch == "amd64" || goarch == "arm64"
-	case "freebsd", "netbsd", "openbsd", "windows":
+	case "freebsd", "netbsd", "windows":
 		return goarch == "amd64"
 	default:
 		return false
diff --git a/src/internal/platform/supported.go b/src/internal/platform/supported.go
index 8f43cbf25f..a774247e6b 100644
--- a/src/internal/platform/supported.go
+++ b/src/internal/platform/supported.go
@@ -26,7 +26,7 @@ func RaceDetectorSupported(goos, goarch string) bool {
 		return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x"
 	case "darwin":
 		return goarch == "amd64" || goarch == "arm64"
-	case "freebsd", "netbsd", "openbsd", "windows":
+	case "freebsd", "netbsd", "windows":
 		return goarch == "amd64"
 	default:
 		return false