From: Dave Cheney <dave@cheney.net>
Date: Tue, 2 Jun 2015 03:28:33 +0000 (+1000)
Subject: cmd/pprof/internal/profile: fix missing error check
X-Git-Tag: go1.5beta1~423
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1831e1ec3725c987c42aef81264433a219756226;p=gostls13.git

cmd/pprof/internal/profile: fix missing error check

Fix missing error check.

Spotted by Gordon Klass, https://groups.google.com/forum/#!topic/golang-nuts/MdDLbvOjb4o

Change-Id: I453a0cf032e0077d2622d5b85030310d159b9c4b
Reviewed-on: https://go-review.googlesource.com/10606
Reviewed-by: Nigel Tao <nigeltao@golang.org>
---

diff --git a/src/cmd/pprof/internal/profile/profile.go b/src/cmd/pprof/internal/profile/profile.go
index 5eb641f7cd..6d175bf32a 100644
--- a/src/cmd/pprof/internal/profile/profile.go
+++ b/src/cmd/pprof/internal/profile/profile.go
@@ -125,11 +125,11 @@ func Parse(r io.Reader) (*Profile, error) {
 
 	var p *Profile
 	if len(orig) >= 2 && orig[0] == 0x1f && orig[1] == 0x8b {
-		var data []byte
-
-		if gz, err := gzip.NewReader(bytes.NewBuffer(orig)); err == nil {
-			data, err = ioutil.ReadAll(gz)
+		gz, err := gzip.NewReader(bytes.NewBuffer(orig))
+		if err != nil {
+			return nil, fmt.Errorf("decompressing profile: %v", err)
 		}
+		data, err := ioutil.ReadAll(gz)
 		if err != nil {
 			return nil, fmt.Errorf("decompressing profile: %v", err)
 		}