From: Dmitry Vyukov <dvyukov@google.com>
Date: Thu, 2 Jul 2015 12:35:23 +0000 (+0200)
Subject: internal/trace: add comment for stable sort
X-Git-Tag: go1.5beta1~19
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1b96091a050d605b900f83e1a28b660729400799;p=gostls13.git

internal/trace: add comment for stable sort

As per comments in cl/11834.

Change-Id: I285536b882fa9496e15d77d0d4c16ee913aca581
Reviewed-on: https://go-review.googlesource.com/11861
Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/internal/trace/parser.go b/src/internal/trace/parser.go
index 1117b18e47..ece5bc188d 100644
--- a/src/internal/trace/parser.go
+++ b/src/internal/trace/parser.go
@@ -254,6 +254,8 @@ func parseEvents(rawEvents []rawEvent) (events []*Event, err error) {
 	}
 
 	// Sort by time and translate cpu ticks to real time.
+	// Use stable sort because adjacent events in a batch can have the same timestamp
+	// (this was observed on some VMs).
 	sort.Stable(eventList(events))
 	if ticksPerSec == 0 {
 		err = fmt.Errorf("no EvFrequency event")