From: Brady Sullivan Date: Mon, 22 Feb 2016 23:19:18 +0000 (-0800) Subject: crypto/tls: Improve ambiguous comment in cipher_suites.go X-Git-Tag: go1.7beta1~1776 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1e00cc1647916b705682f8721b8a9e9e095bf4ee;p=gostls13.git crypto/tls: Improve ambiguous comment in cipher_suites.go A comment existed referencing RC4 coming before AES because of it's vulnerability to the Lucky 13 attack. This clarifies that the Lucky 13 attack only effects AES-CBC, and not AES-GCM. Fixes #14474 Change-Id: Idcb07b5e0cdb0f9257cf75abea60129ba495b5f5 Reviewed-on: https://go-review.googlesource.com/19845 Reviewed-by: Brad Fitzpatrick --- diff --git a/src/crypto/tls/cipher_suites.go b/src/crypto/tls/cipher_suites.go index 869ffa50bd..224ed1bc86 100644 --- a/src/crypto/tls/cipher_suites.go +++ b/src/crypto/tls/cipher_suites.go @@ -74,7 +74,7 @@ type cipherSuite struct { var cipherSuites = []*cipherSuite{ // Ciphersuite order is chosen so that ECDHE comes before plain RSA - // and RC4 comes before AES (because of the Lucky13 attack). + // and RC4 comes before AES-CBC (because of the Lucky13 attack). {TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, 16, 0, 4, ecdheRSAKA, suiteECDHE | suiteTLS12, nil, nil, aeadAESGCM}, {TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, 16, 0, 4, ecdheECDSAKA, suiteECDHE | suiteECDSA | suiteTLS12, nil, nil, aeadAESGCM}, {TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, 32, 0, 4, ecdheRSAKA, suiteECDHE | suiteTLS12 | suiteSHA384, nil, nil, aeadAESGCM},