From: Hector Chu <hectorchu@gmail.com>
Date: Thu, 20 Jan 2011 00:02:47 +0000 (-0500)
Subject: codereview: fix hg change on Windows
X-Git-Tag: weekly.2011-01-19~5
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=1e0efcd5790be98f72c53bfd6c4061bafaafdafc;p=gostls13.git

codereview: fix hg change on Windows

hg change fails on Windows with 'No valid patches found in output from hg diff'.

R=rsc
CC=golang-dev
https://golang.org/cl/4006043
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 0a345d8f66..ab8415e087 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -2607,7 +2607,7 @@ class MercurialVCS(VersionControlSystem):
 			self.base_rev = self.options.revision
 		else:
 			mqparent, err = RunShellWithReturnCode(['hg', 'log', '--rev', 'qparent', '--template={node}'])
-			if not err:
+			if not err and mqparent != "":
 				self.base_rev = mqparent
 			else:
 				self.base_rev = RunShell(["hg", "parents", "-q"]).split(':')[1].strip()