From: Katie Hockman Date: Fri, 10 Sep 2021 13:49:03 +0000 (-0400) Subject: [dev.fuzz] internal/fuzz: improve warning message when not instrumented X-Git-Tag: go1.18beta1~1282^2~14 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=213d9f9a3893eeed1fe1fe5e9e216da33f4d75c4;p=gostls13.git [dev.fuzz] internal/fuzz: improve warning message when not instrumented Change-Id: I005f66c965014b699de7e22750f417b28a32c03f Reviewed-on: https://go-review.googlesource.com/c/go/+/349052 Trust: Katie Hockman Run-TryBot: Katie Hockman TryBot-Result: Go Bot Reviewed-by: Jay Conrod --- diff --git a/src/internal/fuzz/fuzz.go b/src/internal/fuzz/fuzz.go index f36569b4cc..6c07da2dbe 100644 --- a/src/internal/fuzz/fuzz.go +++ b/src/internal/fuzz/fuzz.go @@ -613,11 +613,7 @@ func newCoordinator(opts CoordinateFuzzingOpts) (*coordinator, error) { covSize := len(coverage()) if covSize == 0 { - // TODO: improve this warning. This condition happens if the binary was - // built without fuzzing instrumtation (e.g., with 'go test -c'), so the - // warning may not be true. - fmt.Fprintf(c.opts.Log, "warning: coverage-guided fuzzing is not supported on this platform\n") - c.covOnlyInputs = 0 + fmt.Fprintf(c.opts.Log, "warning: the test binary was not built with coverage instrumentation, so fuzzing will run without coverage guidance and may be inefficient\n") } else { // Set c.coverageData to a clean []byte full of zeros. c.coverageMask = make([]byte, covSize)