From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Fri, 30 Sep 2016 02:35:43 +0000 (-0700)
Subject: net/http: remove TODO about the Server's base context
X-Git-Tag: go1.8beta1~1103
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=214bf6809791170b88b41249850f2f01534725c4;p=gostls13.git

net/http: remove TODO about the Server's base context

I decided not to expand the API for this per discusion on #16220.

Fixes #16220

Change-Id: I65cb2eacd4ec28c79438a8f7c30024524a484ce6
Reviewed-on: https://go-review.googlesource.com/30082
Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/net/http/server.go b/src/net/http/server.go
index 89574a8b36..ef69fbab54 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -2264,9 +2264,7 @@ func (srv *Server) Serve(l net.Listener) error {
 		return err
 	}
 
-	// TODO: allow changing base context? can't imagine concrete
-	// use cases yet.
-	baseCtx := context.Background()
+	baseCtx := context.Background() // base is always background, per Issue 16220
 	ctx := context.WithValue(baseCtx, ServerContextKey, srv)
 	ctx = context.WithValue(ctx, LocalAddrContextKey, l.Addr())
 	for {