From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Wed, 14 Dec 2011 19:20:21 +0000 (-0800)
Subject: http: fix failing Transport HEAD request with gzip-looking response
X-Git-Tag: weekly.2011-12-14~13
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=22dafc9bc5c8b339628a64c9f786491a60031005;p=gostls13.git

http: fix failing Transport HEAD request with gzip-looking response

We only want to attempt to un-gzip if there's a body (not in
response to a HEAD)

This was accidentally passing before, but revealed to be broken
when c3c6e72d7cc went in.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5477093
---

diff --git a/src/pkg/net/http/transport.go b/src/pkg/net/http/transport.go
index dc70be43f2..33ad32861b 100644
--- a/src/pkg/net/http/transport.go
+++ b/src/pkg/net/http/transport.go
@@ -539,12 +539,13 @@ func (pc *persistConn) readLoop() {
 		resp, err := ReadResponse(pc.br, rc.req)
 
 		if err == nil {
-			if rc.addedGzip && resp.Header.Get("Content-Encoding") == "gzip" {
+			hasBody := rc.req.Method != "HEAD" && resp.ContentLength != 0
+			if rc.addedGzip && hasBody && resp.Header.Get("Content-Encoding") == "gzip" {
 				resp.Header.Del("Content-Encoding")
 				resp.Header.Del("Content-Length")
 				resp.ContentLength = -1
 				gzReader, zerr := gzip.NewReader(resp.Body)
-				if err != nil {
+				if zerr != nil {
 					pc.close()
 					err = zerr
 				} else {