From: Brad Fitzpatrick Date: Fri, 21 Oct 2016 11:14:36 +0000 (+0100) Subject: net/http/httptrace: clarify ClientTrace docs X-Git-Tag: go1.8beta1~725 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=23173fc025f769aaa9e19f10aa0f69c851ca2f3b;p=gostls13.git net/http/httptrace: clarify ClientTrace docs The old wording over-promised. Fixes #16957 Change-Id: Iaac04de0d24eb17a0db66beeeab9de70d0f6d391 Reviewed-on: https://go-review.googlesource.com/31735 Reviewed-by: Ian Lance Taylor Reviewed-by: Tom Bergan --- diff --git a/src/net/http/httptrace/trace.go b/src/net/http/httptrace/trace.go index 5b042c097f..807bc4ed69 100644 --- a/src/net/http/httptrace/trace.go +++ b/src/net/http/httptrace/trace.go @@ -68,9 +68,8 @@ func WithClientTrace(ctx context.Context, trace *ClientTrace) context.Context { // ClientTrace is a set of hooks to run at various stages of an outgoing // HTTP request. Any particular hook may be nil. Functions may be -// called concurrently from different goroutines, starting after the -// call to Transport.RoundTrip and ending either when RoundTrip -// returns an error, or when the Response.Body is closed. +// called concurrently from different goroutines and some may be called +// after the request has completed or failed. type ClientTrace struct { // GetConn is called before a connection is created or // retrieved from an idle pool. The hostPort is the