From: Elias Naur Date: Wed, 29 Mar 2017 23:23:20 +0000 (+0200) Subject: misc/cgo/testcshared: use the gold linker on android/arm64 X-Git-Tag: go1.9beta1~921 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=23f56c186d5a1dc198bdbb597b834ce208f09485;p=gostls13.git misc/cgo/testcshared: use the gold linker on android/arm64 The gold linker is used by default in the Android NDK, except on arm64: https://github.com/android-ndk/ndk/issues/148 The Go linker already forces the use of the gold linker on arm and arm64 (CL 22141) for other reasons. However, the test.bash script in testcshared doesn't, resulting in linker errors on android/arm64: warning: liblog.so, needed by ./libgo.so, not found (try using -rpath or -rpath-link) Add -fuse-ld=gold when running testcshared on Android. Fixes the android/arm64 builder. Change-Id: I35ca96f01f136bae72bec56d71b7ca3f344df1ed Reviewed-on: https://go-review.googlesource.com/38832 Run-TryBot: Elias Naur TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- diff --git a/misc/cgo/testcshared/test.bash b/misc/cgo/testcshared/test.bash index a0b9f78658..4ff4db446c 100755 --- a/misc/cgo/testcshared/test.bash +++ b/misc/cgo/testcshared/test.bash @@ -98,7 +98,7 @@ fi GOGCCFLAGS=$(go env GOGCCFLAGS) if [ "$goos" = "android" ]; then - GOGCCFLAGS="${GOGCCFLAGS} -pie" + GOGCCFLAGS="${GOGCCFLAGS} -pie -fuse-ld=gold" fi status=0