From: Damien Neil <dneil@google.com>
Date: Mon, 14 Nov 2022 18:21:51 +0000 (-0800)
Subject: os: don't request read access from CreateFile in Stat
X-Git-Tag: go1.20rc1~283
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=24fc64028c0faa7fcbdae2bf2a2ded825713c982;p=gostls13.git

os: don't request read access from CreateFile in Stat

CL 448897 changed os.Stat to request GENERIC_READ access when using
CreateFile to examine a file. This is unnecessary; access flags of 0
will permit examining file metadata even if the file isn't readable.
Revert to the old behavior here.

For #56217

Change-Id: I09220b3bbee304bd89f4a94ec9b0af42042b7773
Reviewed-on: https://go-review.googlesource.com/c/go/+/450296
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
---

diff --git a/src/os/stat_windows.go b/src/os/stat_windows.go
index 4116e77170..f8f229c709 100644
--- a/src/os/stat_windows.go
+++ b/src/os/stat_windows.go
@@ -69,12 +69,8 @@ func stat(funcname, name string, createFileAttrs uint32) (FileInfo, error) {
 	}
 
 	// Finally use CreateFile.
-	h, err := syscall.CreateFile(namep,
-		syscall.GENERIC_READ,
-		syscall.FILE_SHARE_READ|syscall.FILE_SHARE_WRITE,
-		nil,
-		syscall.OPEN_EXISTING,
-		createFileAttrs, 0)
+	h, err := syscall.CreateFile(namep, 0, 0, nil,
+		syscall.OPEN_EXISTING, createFileAttrs, 0)
 	if err != nil {
 		return nil, &PathError{Op: "CreateFile", Path: name, Err: err}
 	}